cxl/core: Fix initialization of mbox_cmd.size_out in get event
authorKwangjin Ko <kwangjin.ko@sk.com>
Tue, 2 Apr 2024 08:14:03 +0000 (17:14 +0900)
committerDave Jiang <dave.jiang@intel.com>
Wed, 3 Apr 2024 21:25:32 +0000 (14:25 -0700)
commitf7c52345ccc96343c0a05bdea3121c8ac7b67d5f
treea49707cb9991b5a96edcea90dac3a26e5a54382f
parent5c88a9ccd4c431d58b532e4158b6999a8350062c
cxl/core: Fix initialization of mbox_cmd.size_out in get event

Since mbox_cmd.size_out is overwritten with the actual output size in
the function below, it needs to be initialized every time.

cxl_internal_send_cmd -> __cxl_pci_mbox_send_cmd

Problem scenario:

1) The size_out variable is initially set to the size of the mailbox.
2) Read an event.
   - size_out is set to 160 bytes(header 32B + one event 128B).
   - Two event are created while reading.
3) Read the new *two* events.
   - size_out is still set to 160 bytes.
   - Although the value of out_len is 288 bytes, only 160 bytes are
     copied from the mailbox register to the local variable.
   - record_count is set to 2.
   - Accessing records[1] will result in reading incorrect data.

Fixes: 6ebe28f9ec72 ("cxl/mem: Read, trace, and clear events on driver load")
Tested-by: Ira Weiny <ira.weiny@intel.com>
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Kwangjin Ko <kwangjin.ko@sk.com>
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
drivers/cxl/core/mbox.c