pinctrl: s32cc: fix !CONFIG_PM_SLEEP build error
authorArnd Bergmann <arnd@arndb.de>
Fri, 10 Mar 2023 14:02:35 +0000 (15:02 +0100)
committerLinus Walleij <linus.walleij@linaro.org>
Mon, 13 Mar 2023 10:19:39 +0000 (11:19 +0100)
commitf7fc5768e57cc18c24783c524f4e80e680dc4fc4
tree6930eeb85d2b5febe6bdadd8ed0f81ccacff7726
parent3f2d4560898bb7cf579fb78c39f7c77368560414
pinctrl: s32cc: fix !CONFIG_PM_SLEEP build error

The declaration of s32_pinctrl_suspend/s32_pinctrl_resume is hidden
in an #ifdef, causing a compilation failure when CONFIG_PM_SLEEP is
disabled:

drivers/pinctrl/nxp/pinctrl-s32g2.c:754:38: error: 's32_pinctrl_suspend' undeclared here (not in a function); did you mean 's32_pinctrl_probe'?
drivers/pinctrl/nxp/pinctrl-s32g2.c:754:9: note: in expansion of macro 'SET_LATE_SYSTEM_SLEEP_PM_OPS'
  754 |         SET_LATE_SYSTEM_SLEEP_PM_OPS(s32_pinctrl_suspend,
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~

Remove the bogus #ifdef and __maybe_unused annation on the global
functions, and instead use the proper LATE_SYSTEM_SLEEP_PM_OPS()
macro to pick set the function pointer.

As the function definition is still in the #ifdef block, this leads
to the correct code in all configurations.

Fixes: fd84aaa8173d ("pinctrl: add NXP S32 SoC family support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20230310140250.359147-1-arnd@kernel.org
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/nxp/pinctrl-s32.h
drivers/pinctrl/nxp/pinctrl-s32cc.c
drivers/pinctrl/nxp/pinctrl-s32g2.c