staging: vt6656: Return error code in vnt_rf_write_embedded function
authorOscar Carter <oscar.carter@gmx.com>
Tue, 14 Apr 2020 15:38:45 +0000 (17:38 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 16 Apr 2020 10:54:25 +0000 (12:54 +0200)
commitf823cce279368162a161852de189d654a1e61b72
tree6f9d72aa3aa0722646affc56b7470f99dc1fa5e0
parent4a585df3682c54460b1b4b96734d4abc7b816dc7
staging: vt6656: Return error code in vnt_rf_write_embedded function

Use the error code returned by the vnt_control_out function as the
returned value of the vnt_rf_write_embedded function instead of a
boolean value.

Then, fix all vnt_rf_write_embedded calls removing the "and" operations
and replace with a direct assignment to the ret variable and add a check
condition after every call.

Also replace the boolean values true or false in the vnt_rf_set_txpower
function to 0 or error code EINVAL to follow the coding style guide.

The vnt_rf_set_txpower function is called only in the vnt_rf_setpower
function that already returns error codes. The calls to this function
(vnt_rf_set_txpower) not use the returned values, so they not need to be
fixed.

Signed-off-by: Oscar Carter <oscar.carter@gmx.com>
Link: https://lore.kernel.org/r/20200414153849.5785-2-oscar.carter@gmx.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vt6656/rf.c