target/arm/arm-semi: Correct comment about gdb syscall races
authorPeter Maydell <peter.maydell@linaro.org>
Mon, 16 Sep 2019 14:15:32 +0000 (15:15 +0100)
committerPeter Maydell <peter.maydell@linaro.org>
Tue, 15 Oct 2019 17:09:03 +0000 (18:09 +0100)
commitf8ad2306d157a1db494dc0747f9f9afbae72cbda
treebe5c7bfe4d405804d9ea821cd2fd117d9437fed8
parentf7d38cf2d0b35f707ec7a19f71030afbd8fd1491
target/arm/arm-semi: Correct comment about gdb syscall races

In arm_gdb_syscall() we have a comment suggesting a race
because the syscall completion callback might not happen
before the gdb_do_syscallv() call returns. The comment is
correct that the callback may not happen but incorrect about
the effects. Correct it and note the important caveat that
callers must never do any work of any kind after return from
arm_gdb_syscall() that depends on its return value.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20190916141544.17540-4-peter.maydell@linaro.org
target/arm/arm-semi.c