net: free_netdev: exit earlier if dummy
authorBreno Leitao <leitao@debian.org>
Mon, 22 Apr 2024 12:38:55 +0000 (05:38 -0700)
committerDavid S. Miller <davem@davemloft.net>
Wed, 24 Apr 2024 11:00:16 +0000 (12:00 +0100)
commitf8d05679fb3faae478d604177b0c188b340371cd
treea3ac18731f0c1f73eaf0f543355fa9be968a1410
parentc6e7f276841d9a31009766f3e6f33e00cf3d93ed
net: free_netdev: exit earlier if dummy

For dummy devices, exit earlier at free_netdev() instead of executing
the whole function. This is necessary, because dummy devices are
special, and shouldn't have the second part of the function executed.

Otherwise reg_state, which is NETREG_DUMMY, will be overwritten and
there will be no way to identify that this is a dummy device. Also, this
device do not need the final put_device(), since dummy devices are not
registered (through register_netdevice()), where the device reference is
increased (at netdev_register_kobject()/device_add()).

Suggested-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Breno Leitao <leitao@debian.org>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/dev.c