btrfs: ref-verify: fix memory leaks in btrfs_ref_tree_mod()
authorBragatheswaran Manickavel <bragathemanick0908@gmail.com>
Sat, 18 Nov 2023 09:10:12 +0000 (14:40 +0530)
committerDavid Sterba <dsterba@suse.com>
Thu, 23 Nov 2023 21:27:34 +0000 (22:27 +0100)
commitf91192cd68591c6b037da345bc9fcd5e50540358
tree3aa61e39a57905367ff9aba8ba426953ac906245
parent2db313205f8b96eea467691917138d646bb50aef
btrfs: ref-verify: fix memory leaks in btrfs_ref_tree_mod()

In btrfs_ref_tree_mod(), when !parent 're' was allocated through
kmalloc(). In the following code, if an error occurs, the execution will
be redirected to 'out' or 'out_unlock' and the function will be exited.
However, on some of the paths, 're' are not deallocated and may lead to
memory leaks.

For example: lookup_block_entry() for 'be' returns NULL, the out label
will be invoked. During that flow ref and 'ra' are freed but not 're',
which can potentially lead to a memory leak.

CC: stable@vger.kernel.org # 5.10+
Reported-and-tested-by: syzbot+d66de4cbf532749df35f@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=d66de4cbf532749df35f
Signed-off-by: Bragatheswaran Manickavel <bragathemanick0908@gmail.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/ref-verify.c