i3c/master/mipi-i3c-hci: Prefer struct_size over open coded arithmetic
authorLen Baker <len.baker@gmx.com>
Sun, 5 Sep 2021 14:40:54 +0000 (16:40 +0200)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Fri, 10 Dec 2021 14:54:45 +0000 (15:54 +0100)
commitf96b2e77f6d1b0c5181e0eae3dc60a00a5cd692a
treea8c070028e38b46259963bfcb6322acbb4b137e4
parentfa55b7dcdc43c1aa1ba12bca9d2dd4318c2a0dbf
i3c/master/mipi-i3c-hci: Prefer struct_size over open coded arithmetic

As noted in the "Deprecated Interfaces, Language Features, Attributes,
and Conventions" documentation [1], size calculations (especially
multiplication) should not be performed in memory allocator (or similar)
function arguments due to the risk of them overflowing. This could lead
to values wrapping around and a smaller allocation being made than the
caller was expecting. Using those allocations could lead to linear
overflows of heap memory and other misbehaviors.

So, use the struct_size() helper to do the arithmetic instead of the
argument "size + count * size" in the kzalloc() function.

[1] https://www.kernel.org/doc/html/v5.14/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments

Signed-off-by: Len Baker <len.baker@gmx.com>
Acked-by: Nicolas Pitre <npitre@baylibre.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/20210905144054.5124-1-len.baker@gmx.com
drivers/i3c/master/mipi-i3c-hci/dma.c