binfmt_elf: Only report padzero() errors when PROT_WRITE
authorKees Cook <keescook@chromium.org>
Fri, 29 Sep 2023 03:24:33 +0000 (20:24 -0700)
committerKees Cook <keescook@chromium.org>
Wed, 4 Oct 2023 02:48:44 +0000 (19:48 -0700)
commitf9c0a39d95301a36baacfd3495374c6128d662fa
treedf22e1570e2c97f33e272fd5aaa62be52fe56d24
parentd5ca24f639588811af57ceac513183fa2004bd3a
binfmt_elf: Only report padzero() errors when PROT_WRITE

Errors with padzero() should be caught unless we're expecting a
pathological (non-writable) segment. Report -EFAULT only when PROT_WRITE
is present.

Additionally add some more documentation to padzero(), elf_map(), and
elf_load().

Cc: Eric Biederman <ebiederm@xmission.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Christian Brauner <brauner@kernel.org>
Cc: linux-fsdevel@vger.kernel.org
Cc: linux-mm@kvack.org
Suggested-by: Eric Biederman <ebiederm@xmission.com>
Tested-by: Pedro Falcato <pedro.falcato@gmail.com>
Signed-off-by: Sebastian Ott <sebott@redhat.com>
Link: https://lore.kernel.org/r/20230929032435.2391507-5-keescook@chromium.org
Signed-off-by: Kees Cook <keescook@chromium.org>
fs/binfmt_elf.c