projects / qemu.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 39508e7) | patch
scsi: scsi_bus_legacy_handle_cmdline() can fail, fix callers
authorMarkus Armbruster <armbru@redhat.com>
Fri, 25 Jun 2010 16:53:21 +0000 (18:53 +0200)
committerKevin Wolf <kwolf@redhat.com>
Fri, 2 Jul 2010 11:18:01 +0000 (13:18 +0200)
commitfa66b909f382619da15f8c7e323145adfa94fdac
treead7e6948ea9eafbd78633a6d14d25cb5c90a88f1tree | snapshot
parent39508e7adb0de3ef69caa1b494d823d8ac11d3f3commit | diff
scsi: scsi_bus_legacy_handle_cmdline() can fail, fix callers

None of its callers checks for failure.  scsi_hot_add() can crash
because of that:

(qemu) drive_add 4 if=scsi,format=host_device,file=/dev/sg1
scsi-generic: scsi generic interface too old
Segmentation fault (core dumped)

Fix all callers, not just scsi_hot_add().

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
hw/esp.c diff | blob | history
hw/lsi53c895a.c diff | blob | history
hw/pci-hotplug.c diff | blob | history
hw/scsi-bus.c diff | blob | history
hw/scsi.h diff | blob | history
hw/usb-msd.c diff | blob | history
Unnamed repository; edit this file 'description' to name the repository.