linux-user: test, don't assert addr != test in pgb_reserved_va
authorAlex Bennée <alex.bennee@linaro.org>
Tue, 15 Sep 2020 13:43:10 +0000 (14:43 +0100)
committerAlex Bennée <alex.bennee@linaro.org>
Wed, 16 Sep 2020 08:56:39 +0000 (09:56 +0100)
commitfb730c8683807d549c4aa8dfc98e3d1d470fd784
tree8fda933d58401e8516407bddf08a178e085b30ab
parentde39a045bd8d2b49e4f3d07976622c29d58e0bac
linux-user: test, don't assert addr != test in pgb_reserved_va

On older kernels which don't implement MAP_FIXED_NOREPLACE the kernel
may still fail to give us the address we asked for despite having
already probed the map for a valid hole. Asserting isn't particularly
useful to the user so let us move the check up and expand the
error_report a little to give them a fighting chance of working around
the problem.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Cc: Bug 1895080 <1895080@bugs.launchpad.net>
Ameliorates: ee94743034
Message-Id: <20200915134317.11110-2-alex.bennee@linaro.org>
linux-user/elfload.c