selftests/futex: Order calls to futex_lock_pi
authorNysal Jan K.A <nysal@linux.ibm.com>
Mon, 14 Aug 2023 08:09:27 +0000 (13:39 +0530)
committerShuah Khan <skhan@linuxfoundation.org>
Wed, 16 Aug 2023 16:48:10 +0000 (10:48 -0600)
commitfbf4dec702774286db409815ffb077711a96b824
tree646f1ef06fcacb83b22e1c57d0ba9238e9bbcc51
parent888c72d581983ba935d73daed90a7ae4838fc6e1
selftests/futex: Order calls to futex_lock_pi

Observed occassional failures in the futex_wait_timeout test:

ok 1 futex_wait relative succeeds
ok 2 futex_wait_bitset realtime succeeds
ok 3 futex_wait_bitset monotonic succeeds
ok 4 futex_wait_requeue_pi realtime succeeds
ok 5 futex_wait_requeue_pi monotonic succeeds
not ok 6 futex_lock_pi realtime returned 0
......

The test expects the child thread to complete some steps before
the parent thread gets to run. There is an implicit expectation
of the order of invocation of futex_lock_pi between the child thread
and the parent thread. Make this order explicit. If the order is
not met, the futex_lock_pi call in the parent thread succeeds and
will not timeout.

Fixes: f4addd54b161 ("selftests: futex: Expand timeout test")
Signed-off-by: Nysal Jan K.A <nysal@linux.ibm.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
tools/testing/selftests/futex/functional/futex_wait_timeout.c