PCI: mt7621: Fix string truncation in mt7621_pcie_parse_port()
authorSergio Paracuellos <sergio.paracuellos@gmail.com>
Thu, 11 Jan 2024 08:27:04 +0000 (09:27 +0100)
committerKrzysztof Wilczyński <kwilczynski@kernel.org>
Thu, 11 Apr 2024 11:33:48 +0000 (11:33 +0000)
commitfd6eb49a84a85150d5e9ffbd85d3b102303f9470
tree8eacf40702bd101d5ed92b71cdf86a01629198b9
parent4cece764965020c22cff7665b18a012006359095
PCI: mt7621: Fix string truncation in mt7621_pcie_parse_port()

The following warning appears when driver is compiled with W=1.

CC      drivers/pci/controller/pcie-mt7621.o
drivers/pci/controller/pcie-mt7621.c: In function ‘mt7621_pcie_probe’:
drivers/pci/controller/pcie-mt7621.c:228:49: error: ‘snprintf’ output may
be truncated before the last format character [-Werror=format-truncation=]
228 |         snprintf(name, sizeof(name), "pcie-phy%d", slot);
    |                                                 ^
drivers/pci/controller/pcie-mt7621.c:228:9: note: ‘snprintf’ output between
10 and 11 bytes into a destination of size 10
228 |         snprintf(name, sizeof(name), "pcie-phy%d", slot);
    |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Clean this up increasing destination buffer one byte.

[kwilczynski: commit log]
Closes: https://lore.kernel.org/linux-pci/20240110212302.GA2123146@bhelgaas/T/#t
Link: https://lore.kernel.org/linux-pci/20240111082704.2259450-1-sergio.paracuellos@gmail.com
Reported-by: Bjorn Helgaas <helgaas@kernel.org>
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org>
drivers/pci/controller/pcie-mt7621.c