tcp: Fix listen() regression in 5.15.88.
authorKuniyuki Iwashima <kuniyu@amazon.com>
Mon, 13 Feb 2023 20:45:48 +0000 (20:45 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 22 Feb 2023 11:57:06 +0000 (12:57 +0100)
commitfdaf88531cfd17b2a710cceb3141ef6f9085ff40
treede2912109e4c54df00099a0586e93698fa6fbcfc
parent9a1d92cbeac3335fee99fa865b8c5b0f2e71a8f7
tcp: Fix listen() regression in 5.15.88.

When we backport dadd0dcaa67d ("net/ulp: prevent ULP without clone op from
entering the LISTEN status"), we have accidentally backported a part of
7a7160edf1bf ("net: Return errno in sk->sk_prot->get_port().") and removed
err = -EADDRINUSE in inet_csk_listen_start().

Thus, listen() no longer returns -EADDRINUSE even if ->get_port() failed
as reported in [0].

We set -EADDRINUSE to err just before ->get_port() to fix the regression.

[0]: https://lore.kernel.org/stable/EF8A45D0-768A-4CD5-9A8A-0FA6E610ABF7@winter.cafe/

Reported-by: Winter <winter@winter.cafe>
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/ipv4/inet_connection_sock.c