dmaengine: milbeaut-hdmac: Prefer kcalloc over open coded arithmetic
authorLen Baker <len.baker@gmx.com>
Sat, 4 Sep 2021 14:58:13 +0000 (16:58 +0200)
committerVinod Koul <vkoul@kernel.org>
Mon, 25 Oct 2021 06:42:13 +0000 (12:12 +0530)
commitfe14c67267886e3af3c377a7bee4e6f915778636
tree0a20abc20a5a6d55710f0aa11bd061a30a5ac350
parentdbe3c54e71051b50a4aa863502368000d3e7701f
dmaengine: milbeaut-hdmac: Prefer kcalloc over open coded arithmetic

As noted in the "Deprecated Interfaces, Language Features, Attributes,
and Conventions" documentation [1], size calculations (especially
multiplication) should not be performed in memory allocator (or similar)
function arguments due to the risk of them overflowing. This could lead
to values wrapping around and a smaller allocation being made than the
caller was expecting. Using those allocations could lead to linear
overflows of heap memory and other misbehaviors.

So, use the purpose specific kcalloc() function instead of the argument
size * count in the kzalloc() function.

[1] https://www.kernel.org/doc/html/v5.14/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments

Signed-off-by: Len Baker <len.baker@gmx.com>
Link: https://lore.kernel.org/r/20210904145813.5161-1-len.baker@gmx.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/milbeaut-hdmac.c