regmap: fix bogus error on regcache_sync success
authorMatthias Reichl <hias@horus.com>
Sun, 3 Dec 2023 22:22:16 +0000 (23:22 +0100)
committerMark Brown <broonie@kernel.org>
Mon, 4 Dec 2023 12:36:55 +0000 (12:36 +0000)
commitfea88064445a59584460f7f67d102b6e5fc1ca1d
tree79a26ffbd2dc4e86b426f91b5e9afadb28d12262
parentb85ea95d086471afb4ad062012a4d73cd328fa86
regmap: fix bogus error on regcache_sync success

Since commit 0ec7731655de ("regmap: Ensure range selector registers
are updated after cache sync") opening pcm512x based soundcards fail
with EINVAL and dmesg shows sync cache and pm_runtime_get errors:

[  228.794676] pcm512x 1-004c: Failed to sync cache: -22
[  228.794740] pcm512x 1-004c: ASoC: error at snd_soc_pcm_component_pm_runtime_get on pcm512x.1-004c: -22

This is caused by the cache check result leaking out into the
regcache_sync return value.

Fix this by making the check local-only, as the comment above the
regcache_read call states a non-zero return value means there's
nothing to do so the return value should not be altered.

Fixes: 0ec7731655de ("regmap: Ensure range selector registers are updated after cache sync")
Cc: stable@vger.kernel.org
Signed-off-by: Matthias Reichl <hias@horus.com>
Link: https://lore.kernel.org/r/20231203222216.96547-1-hias@horus.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/base/regmap/regcache.c