media: atomisp: drop contiguous argument from ia_css_frame_allocate_with_buffer_size()
authorHans de Goede <hdegoede@redhat.com>
Wed, 15 Jun 2022 20:50:00 +0000 (21:50 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Fri, 8 Jul 2022 15:11:06 +0000 (16:11 +0100)
Drop the contiguous argument from ia_css_frame_allocate_with_buffer_size()
its only caller always passes false.

Link: https://lore.kernel.org/linux-media/20220615205037.16549-4-hdegoede@redhat.com
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/staging/media/atomisp/pci/runtime/frame/interface/ia_css_frame.h
drivers/staging/media/atomisp/pci/runtime/frame/src/frame.c
drivers/staging/media/atomisp/pci/sh_css_mipi.c

index c756a134efc3bcf7794a353cef164fb24c4a01fa..700070c58eda04c5ef5b20ed86cf688048ab143a 100644 (file)
@@ -109,16 +109,13 @@ void ia_css_frame_free_multiple(unsigned int num_frames,
  *
  * @param      frame   The allocated frame.
  * @param[in]  size_bytes      The frame size in bytes.
- * @param[in]  contiguous      Allocate memory physically contiguously or not.
  * @return     The error code.
  *
  * Allocate a frame using the given size in bytes.
  * The frame structure is partially null initialized.
  */
-int ia_css_frame_allocate_with_buffer_size(
-    struct ia_css_frame **frame,
-    const unsigned int size_bytes,
-    const bool contiguous);
+int ia_css_frame_allocate_with_buffer_size(struct ia_css_frame **frame,
+                                          const unsigned int size_bytes);
 
 /* @brief Check whether 2 frames are same type
  *
index 1d8017fc3f7050bdec7468152b58eee80b974543..7a119d2c9256dfb3a52649d1a79b74948f50ca17 100644 (file)
@@ -486,16 +486,14 @@ void ia_css_frame_free_multiple(unsigned int num_frames,
        }
 }
 
-int ia_css_frame_allocate_with_buffer_size(
-    struct ia_css_frame **frame,
-    const unsigned int buffer_size_bytes,
-    const bool contiguous)
+int ia_css_frame_allocate_with_buffer_size(struct ia_css_frame **frame,
+                                          const unsigned int buffer_size_bytes)
 {
        /* AM: Body coppied from frame_allocate_with_data(). */
        int err;
        struct ia_css_frame *me = frame_create(0, 0,
                                               IA_CSS_FRAME_FORMAT_NUM,/* Not valid format yet */
-                                              0, 0, contiguous, false);
+                                              0, 0, false, false);
 
        if (!me)
                return -ENOMEM;
index 0acf75497ae77bbb4c317edaf6b526f792cfd90b..bc6e8598a776db36bce345640ac41e8edd0c9200 100644 (file)
@@ -431,8 +431,7 @@ allocate_mipi_frames(struct ia_css_pipe *pipe,
                                /* allocate new frame */
                                err = ia_css_frame_allocate_with_buffer_size(
                                          &my_css.mipi_frames[port][i],
-                                         my_css.mipi_frame_size[port] * HIVE_ISP_DDR_WORD_BYTES,
-                                         false);
+                                         my_css.mipi_frame_size[port] * HIVE_ISP_DDR_WORD_BYTES);
                                if (err) {
                                        for (j = 0; j < i; j++) {
                                                if (my_css.mipi_frames[port][j]) {