firmware: arm_ffa: Remove incorrect assignment of driver_data
authorSudeep Holla <sudeep.holla@arm.com>
Fri, 29 Apr 2022 11:39:44 +0000 (12:39 +0100)
committerSudeep Holla <sudeep.holla@arm.com>
Fri, 29 Apr 2022 13:51:46 +0000 (14:51 +0100)
The ffa core driver currently assigns its own driver information
to individual ffa device driver_data which is wrong. Firstly, it leaks
this core driver information to individual ffa_device and hence to
ffa_driver. Secondly the ffa_device driver_data is for use by individual
ffa_driver and not for this core driver managing all those devices.

Link: https://lore.kernel.org/r/20220429113946.2087145-2-sudeep.holla@arm.com
Fixes: d0c0bce83122 ("firmware: arm_ffa: Setup in-kernel users of FFA partitions")
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
drivers/firmware/arm_ffa/driver.c

index 6a913ac91e8e07ea37028170cab8d5d3aae485e9..ec731e9e942b8825efdcd6038b513ac8154c09f3 100644 (file)
@@ -694,8 +694,6 @@ static void ffa_setup_partitions(void)
                               __func__, tpbuf->id);
                        continue;
                }
-
-               ffa_dev_set_drvdata(ffa_dev, drv_info);
        }
        kfree(pbuf);
 }