ASoC: Intel: sof_maxim_common: check return value
authorBard Liao <yung-chuan.liao@linux.intel.com>
Mon, 27 Nov 2023 15:26:30 +0000 (17:26 +0200)
committerMark Brown <broonie@kernel.org>
Mon, 27 Nov 2023 16:32:50 +0000 (16:32 +0000)
snd_soc_dai_set_tdm_slot() could return error.

Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Chao Song <chao.song@linux.intel.com>
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Link: https://lore.kernel.org/r/20231127152654.28204-4-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/intel/boards/sof_maxim_common.c

index f64124077ca7e8eb8c8f41d79b957e3ef21cdcaf..cf29747182716c500447b3e8b36dc12cfdcee000 100644 (file)
@@ -61,15 +61,21 @@ static int max_98373_hw_params(struct snd_pcm_substream *substream,
 {
        struct snd_soc_pcm_runtime *rtd = snd_soc_substream_to_rtd(substream);
        struct snd_soc_dai *codec_dai;
+       int ret = 0;
        int j;
 
        for_each_rtd_codec_dais(rtd, j, codec_dai) {
                if (!strcmp(codec_dai->component->name, MAX_98373_DEV0_NAME)) {
                        /* DEV0 tdm slot configuration */
-                       snd_soc_dai_set_tdm_slot(codec_dai, 0x03, 3, 8, 32);
+                       ret = snd_soc_dai_set_tdm_slot(codec_dai, 0x03, 3, 8, 32);
                } else if (!strcmp(codec_dai->component->name, MAX_98373_DEV1_NAME)) {
                        /* DEV1 tdm slot configuration */
-                       snd_soc_dai_set_tdm_slot(codec_dai, 0x0C, 3, 8, 32);
+                       ret = snd_soc_dai_set_tdm_slot(codec_dai, 0x0C, 3, 8, 32);
+               }
+               if (ret < 0) {
+                       dev_err(codec_dai->dev, "fail to set tdm slot, ret %d\n",
+                               ret);
+                       return ret;
                }
        }
        return 0;