bcachefs: Fix promote path leak
authorKent Overstreet <kent.overstreet@linux.dev>
Thu, 5 Jan 2023 08:55:23 +0000 (03:55 -0500)
committerKent Overstreet <kent.overstreet@linux.dev>
Sun, 22 Oct 2023 21:09:52 +0000 (17:09 -0400)
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
fs/bcachefs/io.c

index 93d300812b4bcace6bed798387d086c4b57b4fe0..1436863fe418a79b67a7299f83e3cd4805a9c07f 100644 (file)
@@ -1924,6 +1924,8 @@ static void promote_free(struct bch_fs *c, struct promote_op *op)
 {
        int ret;
 
+       bch2_data_update_exit(&op->write);
+
        ret = rhashtable_remove_fast(&c->promote_table, &op->hash,
                                     bch_promote_params);
        BUG_ON(ret);
@@ -1939,8 +1941,6 @@ static void promote_done(struct bch_write_op *wop)
 
        bch2_time_stats_update(&c->times[BCH_TIME_data_promote],
                               op->start_time);
-
-       bch2_data_update_exit(&op->write);
        promote_free(c, op);
 }