staging: r8188eu: refactor rtw_inc_and_chk_continual_urb_error()
authorMichael Straube <straube.linux@gmail.com>
Tue, 29 Mar 2022 10:37:54 +0000 (12:37 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 4 Apr 2022 05:33:47 +0000 (07:33 +0200)
Refactor rtw_inc_and_chk_continual_urb_error(). Return directly
instead of using a return variable and initialize the variable 'value'
at declaration. This shortens the code and improves readability.

Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20220329103756.6740-3-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/r8188eu/include/usb_ops.h

index 3416c8baceb6d9ed51edd353261bb4d990ac76bd..cfcf6f84d2cf63dec23fa0da0a464e35c0f14383 100644 (file)
  */
 static inline int rtw_inc_and_chk_continual_urb_error(struct dvobj_priv *dvobj)
 {
-       int ret = false;
-       int value;
-       value = atomic_inc_return(&dvobj->continual_urb_error);
+       int value = atomic_inc_return(&dvobj->continual_urb_error);
+
        if (value > MAX_CONTINUAL_URB_ERR)
-               ret = true;
+               return true;
 
-       return ret;
+       return false;
 }
 
 /*