projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
71933fb
)
bcachefs: Remove a redundant and harmless bch2_free_super() call
author
Christophe JAILLET
<christophe.jaillet@wanadoo.fr>
Wed, 13 Sep 2023 16:44:09 +0000
(18:44 +0200)
committer
Kent Overstreet
<kent.overstreet@linux.dev>
Sun, 22 Oct 2023 21:10:13 +0000
(17:10 -0400)
Remove a redundant call to bch2_free_super().
This is harmless because bch2_free_super() has a memset() at its end. So
a second call would only lead to from kfree(NULL).
Remove the redundant call and only rely on the error handling path.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
fs/bcachefs/super.c
patch
|
blob
|
history
diff --git
a/fs/bcachefs/super.c
b/fs/bcachefs/super.c
index 9f852a6dd76a1134f2796136a9cb8ae152e2bad1..2990eed85adf5ecdcb788dfcc9e5cee6f44917ca 100644
(file)
--- a/
fs/bcachefs/super.c
+++ b/
fs/bcachefs/super.c
@@
-1605,7
+1605,6
@@
int bch2_dev_add(struct bch_fs *c, const char *path)
ca = __bch2_dev_alloc(c, &dev_mi);
if (!ca) {
- bch2_free_super(&sb);
ret = -ENOMEM;
goto err;
}