wifi: ath12k: fix incorrect logic of calculating vdev_stats_id

During calculate vdev_stats_id, will compare vdev_stats_id with
ATH12K_INVAL_VDEV_STATS_ID by '<='. If vdev_stats_id is relatively
small, then assign ATH12K_INVAL_VDEV_STATS_ID to vdev_stats_id.

This logic is incorrect. Firstly, should use '>=' instead of '<=' to
check if this u8 variable exceeds the max valid range.

Secondly, should use the maximum value as comparison value.

Correct comparison symbols and use the maximum value
ATH12K_MAX_VDEV_STATS_ID for comparison.

Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3

Fixes: d889913205cf ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices")
Signed-off-by: Kang Yang <quic_kangyang@quicinc.com>
Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>
Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Link: https://msgid.link/20240130040303.370590-3-quic_kangyang@quicinc.com

diff --git a/drivers/net/wireless/ath/ath12k/mac.c b/drivers/net/wireless/ath/ath12k/mac.c
index fb5bf500ed8726647b1991bc09c1a12ecc108624..078dda43dded318a852ad15726dfceec9b77518e 100644 (file)
--- a/drivers/net/wireless/ath/ath12k/mac.c
+++ b/drivers/net/wireless/ath/ath12k/mac.c
@@ -5421,7 +5421,7 @@ ath12k_mac_get_vdev_stats_id(struct ath12k_vif *arvif)
        do {
                if (ab->free_vdev_stats_id_map & (1LL << vdev_stats_id)) {
                        vdev_stats_id++;
-                       if (vdev_stats_id <= ATH12K_INVAL_VDEV_STATS_ID) {
+                       if (vdev_stats_id >= ATH12K_MAX_VDEV_STATS_ID) {
                                vdev_stats_id = ATH12K_INVAL_VDEV_STATS_ID;
                                break;
                        }