tests/multiboot: Fix whitespace failure
authorEric Blake <eblake@redhat.com>
Tue, 8 Aug 2017 14:34:16 +0000 (09:34 -0500)
committerKevin Wolf <kwolf@redhat.com>
Fri, 11 Aug 2017 11:23:19 +0000 (13:23 +0200)
Commit b43671f8 accidentally broke run_test.sh within tests/multiboot;
due to a subtle change in whitespace.

These two commands produce theh same output (at least, for sane $IFS
of space-tab-newline):

echo -e "...$@..."
echo -e "...$*..."

But that's only because echo inserts spaces between multiple arguments
(the $@ case), while the $* form gives a single argument to echo with
the spaces already present.

But when converting to printf %b, there are no automatic spaces between
multiple arguments, so we HAVE to use $*.

It doesn't help that run_test.sh isn't part of 'make check'.

Signed-off-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
tests/multiboot/run_test.sh

index c8f3da8f3720be1dbe00c32d258aba9b099f1566..0278148b4338ccb91e0fc6e74279b0abbd36a658 100755 (executable)
@@ -26,7 +26,7 @@ run_qemu() {
     local kernel=$1
     shift
 
-    printf %b "\n\n=== Running test case: $kernel $@ ===\n\n" >> test.log
+    printf %b "\n\n=== Running test case: $kernel $* ===\n\n" >> test.log
 
     $QEMU \
         -kernel $kernel \