iwlwifi: Fix -EIO error code that is never returned
authorColin Ian King <colin.king@canonical.com>
Tue, 7 Sep 2021 10:46:58 +0000 (11:46 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 8 Apr 2022 12:23:32 +0000 (14:23 +0200)
[ Upstream commit c305c94bdc18e45b5ad1db54da4269f8cbfdff6b ]

Currently the error -EIO is being assinged to variable ret when
the READY_BIT is not set but the function iwlagn_mac_start returns
0 rather than ret. Fix this by returning ret instead of 0.

Addresses-Coverity: ("Unused value")
Fixes: 7335613ae27a ("iwlwifi: move all mac80211 related functions to one place")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/20210907104658.14706-1-colin.king@canonical.com
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/wireless/intel/iwlwifi/dvm/mac80211.c

index 75e7665773c52ca1859e93bc4e88e030951387a0..90fe4adca49263c76691f918c431d7576580faf7 100644 (file)
@@ -304,7 +304,7 @@ static int iwlagn_mac_start(struct ieee80211_hw *hw)
 
        priv->is_open = 1;
        IWL_DEBUG_MAC80211(priv, "leave\n");
-       return 0;
+       return ret;
 }
 
 static void iwlagn_mac_stop(struct ieee80211_hw *hw)