fs/ntfs3: Fix wrong cast in xattr.c
authorDaniel Pinto <danielpinto52@gmail.com>
Tue, 15 Nov 2022 08:17:32 +0000 (08:17 +0000)
committerKonstantin Komarov <almaz.alexandrovich@paragon-software.com>
Mon, 27 Mar 2023 12:59:07 +0000 (16:59 +0400)
cpu_to_be32 and be32_to_cpu respectively return and receive
__be32, change the cast to the correct types.

Fixes the following sparse warnings:
fs/ntfs3/xattr.c:811:48: sparse: sparse: incorrect type in
                         assignment (different base types)
fs/ntfs3/xattr.c:901:34: sparse: sparse: cast to restricted __be32

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Daniel Pinto <danielpinto52@gmail.com>
Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
fs/ntfs3/xattr.c

index ff64302e87e5846c6b26735f8d096df6403612ed..f8043838eb92fa6c5b1852043a226fdac1e06668 100644 (file)
@@ -780,7 +780,7 @@ static int ntfs_getxattr(const struct xattr_handler *handler, struct dentry *de,
                        err = sizeof(u32);
                        *(u32 *)buffer = le32_to_cpu(ni->std_fa);
                        if (!strcmp(name, SYSTEM_NTFS_ATTRIB_BE))
-                               *(u32 *)buffer = cpu_to_be32(*(u32 *)buffer);
+                               *(__be32 *)buffer = cpu_to_be32(*(u32 *)buffer);
                }
                goto out;
        }
@@ -857,7 +857,7 @@ static noinline int ntfs_setxattr(const struct xattr_handler *handler,
                if (size != sizeof(u32))
                        goto out;
                if (!strcmp(name, SYSTEM_NTFS_ATTRIB_BE))
-                       new_fa = cpu_to_le32(be32_to_cpu(*(u32 *)value));
+                       new_fa = cpu_to_le32(be32_to_cpu(*(__be32 *)value));
                else
                        new_fa = cpu_to_le32(*(u32 *)value);