drm/xe/xe_exec : In xe_exec_ioctl remove deadcode
authorHimal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
Wed, 13 Mar 2024 15:05:45 +0000 (20:35 +0530)
committerRodrigo Vivi <rodrigo.vivi@intel.com>
Wed, 13 Mar 2024 20:00:26 +0000 (16:00 -0400)
At label err_unlock_list the condition write_label will never be true.
Remove the deadcode line for write_label true.

Reported by static analyzer.

Cc: Matthew Brost <matthew.brost@intel.com>
Cc: Tejas Upadhyay <tejas.upadhyay@intel.com>
Cc: Bommu Krishnaiah <krishnaiah.bommu@intel.com>
Reviewed-by: Tejas Upadhyay <tejas.upadhyay@intel.com>
Signed-off-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240313150545.2830408-3-himal.prasad.ghimiray@intel.com
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
drivers/gpu/drm/xe/xe_exec.c

index 952496c6260dfb5c3e9f798137cd4737a4040acb..acc066e405d00cc91d308af6534cd5b22956193a 100644 (file)
@@ -380,10 +380,7 @@ err_put_job:
 err_exec:
        drm_exec_fini(exec);
 err_unlock_list:
-       if (write_locked)
-               up_write(&vm->lock);
-       else
-               up_read(&vm->lock);
+       up_read(&vm->lock);
        if (err == -EAGAIN && !skip_retry)
                goto retry;
 err_syncs: