ALSA: hda: cs35l41: Always configure the DAI
authorLucas Tanure <tanureal@opensource.cirrus.com>
Wed, 13 Apr 2022 08:37:17 +0000 (09:37 +0100)
committerTakashi Iwai <tiwai@suse.de>
Wed, 13 Apr 2022 08:42:33 +0000 (10:42 +0200)
The dai configuration is always the same and should always configured
during the opening the stream.

Signed-off-by: Lucas Tanure <tanureal@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20220413083728.10730-6-tanureal@opensource.cirrus.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/cs35l41_hda.c

index d2addae8c085c3bd323522b87ca725b5cd9ceafa..f853530eb3852a341fe2b72e1b8110084a99b73e 100644 (file)
@@ -111,8 +111,6 @@ static const struct reg_sequence cs35l41_reset_to_safe[] = {
 static const struct cs35l41_hda_reg_sequence cs35l41_hda_reg_seq_no_bst = {
        .probe          = cs35l41_reset_to_safe,
        .num_probe      = ARRAY_SIZE(cs35l41_reset_to_safe),
-       .open           = cs35l41_hda_config,
-       .num_open       = ARRAY_SIZE(cs35l41_hda_config),
        .prepare        = cs35l41_safe_to_active,
        .num_prepare    = ARRAY_SIZE(cs35l41_safe_to_active),
        .cleanup        = cs35l41_active_to_safe,
@@ -120,8 +118,6 @@ static const struct cs35l41_hda_reg_sequence cs35l41_hda_reg_seq_no_bst = {
 };
 
 static const struct cs35l41_hda_reg_sequence cs35l41_hda_reg_seq_ext_bst = {
-       .open           = cs35l41_hda_config,
-       .num_open       = ARRAY_SIZE(cs35l41_hda_config),
        .prepare        = cs35l41_start_ext_vspk,
        .num_prepare    = ARRAY_SIZE(cs35l41_start_ext_vspk),
        .cleanup        = cs35l41_stop_ext_vspk,
@@ -129,8 +125,6 @@ static const struct cs35l41_hda_reg_sequence cs35l41_hda_reg_seq_ext_bst = {
 };
 
 static const struct cs35l41_hda_reg_sequence cs35l41_hda_reg_seq_int_bst = {
-       .open           = cs35l41_hda_config,
-       .num_open       = ARRAY_SIZE(cs35l41_hda_config),
        .prepare        = cs35l41_hda_start_bst,
        .num_prepare    = ARRAY_SIZE(cs35l41_hda_start_bst),
        .cleanup        = cs35l41_hda_stop_bst,
@@ -146,8 +140,8 @@ static void cs35l41_hda_playback_hook(struct device *dev, int action)
 
        switch (action) {
        case HDA_GEN_PCM_ACT_OPEN:
-               if (reg_seq->open)
-                       ret = regmap_multi_reg_write(reg, reg_seq->open, reg_seq->num_open);
+               ret = regmap_multi_reg_write(reg, cs35l41_hda_config,
+                                            ARRAY_SIZE(cs35l41_hda_config));
                break;
        case HDA_GEN_PCM_ACT_PREPARE:
                if (reg_seq->prepare)