habanalabs: remove redundant cs validity checks
authorOfir Bitton <obitton@habana.ai>
Mon, 13 Sep 2021 07:55:02 +0000 (10:55 +0300)
committerOded Gabbay <ogabbay@kernel.org>
Mon, 18 Oct 2021 09:05:46 +0000 (12:05 +0300)
During TDR handling, we check multiple times if CS is valid.
No need to perform this check as CS must be valid at all time
during the TDR handling.

Signed-off-by: Ofir Bitton <obitton@habana.ai>
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
drivers/misc/habanalabs/common/command_submission.c

index 6dafff375f1c6e614010552e79f5b52292cfb1af..a344928363c8c53fb2150c29b8d46fb3c1ee3c73 100644 (file)
@@ -431,11 +431,10 @@ static void cs_handle_tdr(struct hl_device *hdev, struct hl_cs *cs)
        /* Don't cancel TDR in case this CS was timedout because we might be
         * running from the TDR context
         */
-       if (cs && (cs->timedout ||
-                       hdev->timeout_jiffies == MAX_SCHEDULE_TIMEOUT))
+       if (cs->timedout || hdev->timeout_jiffies == MAX_SCHEDULE_TIMEOUT)
                return;
 
-       if (cs && cs->tdr_active)
+       if (cs->tdr_active)
                cancel_delayed_work_sync(&cs->work_tdr);
 
        spin_lock(&hdev->cs_mirror_lock);