platform/x86/amd/hsmp: Fix iomem handling
authorArmin Wolf <W_Armin@gmx.de>
Thu, 19 Oct 2023 13:51:22 +0000 (15:51 +0200)
committerIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Wed, 25 Oct 2023 09:29:44 +0000 (12:29 +0300)
Since the metrics table is marked as io memory, use memcpy_fromio()
when copying its contents.

Compile-tested only.

Fixes: 5150542b8ec5 ("platform/x86/amd/hsmp: add support for metrics tbl")
Signed-off-by: Armin Wolf <W_Armin@gmx.de>
Link: https://lore.kernel.org/r/20231019135122.21774-1-W_Armin@gmx.de
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
drivers/platform/x86/amd/hsmp.c

index b056a5c8654a2613561707ec3972e899592d233b..b55d80e291393e902bb2b9786ce78eb0c39e1ab9 100644 (file)
@@ -362,7 +362,7 @@ static ssize_t hsmp_metric_tbl_read(struct file *filp, struct kobject *kobj,
        ret = hsmp_send_message(&msg);
        if (ret)
                return ret;
-       memcpy(buf, sock->metric_tbl_addr, bin_attr->size);
+       memcpy_fromio(buf, sock->metric_tbl_addr, bin_attr->size);
 
        return bin_attr->size;
 }