soc: mediatek: mtk-svs: Use devm variant for dev_pm_opp_of_add_table()
authorAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Tue, 26 Jul 2022 14:16:52 +0000 (16:16 +0200)
committerMatthias Brugger <matthias.bgg@gmail.com>
Thu, 25 Aug 2022 13:27:57 +0000 (15:27 +0200)
In error cases, this driver never calls dev_pm_opp_of_remove_table():
instead of doing that, simple switch to a devm variant, which will
automagically do that for us.

Fixes: 681a02e95000 ("soc: mediatek: SVS: introduce MTK SVS engine")
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://lore.kernel.org/r/20220726141653.177948-6-angelogioacchino.delregno@collabora.com
Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
drivers/soc/mediatek/mtk-svs.c

index dde95aa160e95355c76371120fba843f58be4633..d96b9d3f3a8300e8c22265eb3b81d6090ede57b5 100644 (file)
@@ -1586,7 +1586,7 @@ static int svs_bank_resource_setup(struct svs_platform *svsp)
 
                dev_set_drvdata(svsb->dev, svsp);
 
-               ret = dev_pm_opp_of_add_table(svsb->opp_dev);
+               ret = devm_pm_opp_of_add_table(svsb->opp_dev);
                if (ret) {
                        dev_err(svsb->dev, "add opp table fail: %d\n", ret);
                        return ret;