staging: gasket: page table: remove dead code in coherent mem alloc
authorTodd Poynor <toddpoynor@google.com>
Mon, 15 Oct 2018 04:59:19 +0000 (21:59 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 15 Oct 2018 14:30:37 +0000 (16:30 +0200)
gasket_alloc_coherent_memory() has some unnecessary code related to out
of memory checking that will never hit the condition checked, remove.

Signed-off-by: Todd Poynor <toddpoynor@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/gasket/gasket_page_table.c

index 2e1de8ad4a2c63fe442cca529433bf37f3ad2e0b..985a3a93499d5e34b4914124d72a67e4e071fc59 100644 (file)
@@ -1316,7 +1316,6 @@ int gasket_alloc_coherent_memory(struct gasket_dev *gasket_dev, u64 size,
                        GFP_KERNEL);
        if (!gasket_dev->page_table[index]->coherent_pages)
                goto nomem;
-       *dma_address = 0;
 
        gasket_dev->coherent_buffer.length_bytes =
                PAGE_SIZE * (num_pages);
@@ -1331,15 +1330,12 @@ int gasket_alloc_coherent_memory(struct gasket_dev *gasket_dev, u64 size,
                        (u64)mem + j * PAGE_SIZE;
        }
 
-       if (*dma_address == 0)
-               goto nomem;
        return 0;
 
 nomem:
-       if (mem) {
+       if (mem)
                dma_free_coherent(gasket_get_device(gasket_dev),
                                  num_pages * PAGE_SIZE, mem, handle);
-       }
 
        kfree(gasket_dev->page_table[index]->coherent_pages);
        gasket_dev->page_table[index]->coherent_pages = NULL;