drm/i915/fence: replace BUG_ON() with BUILD_BUG_ON()

Avoid BUG_ON(). Since __i915_sw_fence_init() is always called via a
wrapper macro, we can replace it with a compile time BUILD_BUG_ON().

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220830093411.1511040-5-jani.nikula@intel.com

diff --git a/drivers/gpu/drm/i915/i915_sw_fence.c b/drivers/gpu/drm/i915/i915_sw_fence.c
index ae984c66c48a99b2cf808800c0de0c317e05b2dd..6fc0d1b89690210a762c8ae2106c0fe85b006b80 100644 (file)
--- a/drivers/gpu/drm/i915/i915_sw_fence.c
+++ b/drivers/gpu/drm/i915/i915_sw_fence.c
@@ -241,8 +241,6 @@ void __i915_sw_fence_init(struct i915_sw_fence *fence,
                          const char *name,
                          struct lock_class_key *key)
 {
-       BUG_ON(!fn);
-
        __init_waitqueue_head(&fence->wait, name, key);
        fence->fn = fn;
 #ifdef CONFIG_DRM_I915_SW_FENCE_CHECK_DAG

diff --git a/drivers/gpu/drm/i915/i915_sw_fence.h b/drivers/gpu/drm/i915/i915_sw_fence.h
index a7c603bc1b01c9a218b4a76a29050e69c0f3bf95..619fc5a22f0c7bbfd2ea1da4c47f7dd5165e5ccb 100644 (file)
--- a/drivers/gpu/drm/i915/i915_sw_fence.h
+++ b/drivers/gpu/drm/i915/i915_sw_fence.h
@@ -48,11 +48,15 @@ void __i915_sw_fence_init(struct i915_sw_fence *fence,
 do {                                                           \
        static struct lock_class_key __key;                     \
                                                                \
+       BUILD_BUG_ON((fn) == NULL);                             \
        __i915_sw_fence_init((fence), (fn), #fence, &__key);    \
 } while (0)
 #else
 #define i915_sw_fence_init(fence, fn)                          \
-       __i915_sw_fence_init((fence), (fn), NULL, NULL)
+do {                                                           \
+       BUILD_BUG_ON((fn) == NULL);                             \
+       __i915_sw_fence_init((fence), (fn), NULL, NULL);        \
+} while (0)
 #endif
 
 void i915_sw_fence_reinit(struct i915_sw_fence *fence);