spi: mxs: fix reference leak in mxs_spi_probe

pm_runtime_get_sync will increment pm usage counter even it
failed. Forgetting to pm_runtime_put_noidle will result in
reference leak in mxs_spi_probe, so we should fix it.

Fixes: b7969caf41a1d ("spi: mxs: implement runtime pm")
Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
Link: https://lore.kernel.org/r/20201106012421.95420-1-zhangqilong3@huawei.com
Signed-off-by: Mark Brown <broonie@kernel.org>

diff --git a/drivers/spi/spi-mxs.c b/drivers/spi/spi-mxs.c
index 918918a9e04914262c93fcafe6fd490169010ac9..435309b09227ea3297651a51531ab429538b48e3 100644 (file)
--- a/drivers/spi/spi-mxs.c
+++ b/drivers/spi/spi-mxs.c
@@ -607,6 +607,7 @@ static int mxs_spi_probe(struct platform_device *pdev)
 
        ret = pm_runtime_get_sync(ssp->dev);
        if (ret < 0) {
+               pm_runtime_put_noidle(ssp->dev);
                dev_err(ssp->dev, "runtime_get_sync failed\n");
                goto out_pm_runtime_disable;
        }