spi: sprd-adi: checking for NULL instead of IS_ERR()
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 25 Sep 2017 10:21:33 +0000 (13:21 +0300)
committerMark Brown <broonie@kernel.org>
Mon, 25 Sep 2017 16:08:20 +0000 (17:08 +0100)
devm_ioremap_resource() returns error pointers, it never returns NULL.

Fixes: 7e2903cb91df ("spi: Add ADI driver for Spreadtrum platform")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-sprd-adi.c

index 0d481f8a46c201cad248e8374077fed8f1074bf1..bff6ef1caad77bed33fe1f5a06d4fde6523ee7ed 100644 (file)
@@ -341,8 +341,8 @@ static int sprd_adi_probe(struct platform_device *pdev)
 
        res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
        sadi->base = devm_ioremap_resource(&pdev->dev, res);
-       if (!sadi->base) {
-               ret = -ENOMEM;
+       if (IS_ERR(sadi->base)) {
+               ret = PTR_ERR(sadi->base);
                goto put_ctlr;
        }