f2fs: add static init_idisk_time function to reduce the code
authorZhang Qilong <zhangqilong3@huawei.com>
Wed, 31 Aug 2022 09:48:15 +0000 (17:48 +0800)
committerJaegeuk Kim <jaegeuk@kernel.org>
Tue, 4 Oct 2022 20:31:42 +0000 (13:31 -0700)
We can use a inner function to init the disk time
of f2fs_inode_info for cleaning redundant code.

Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
fs/f2fs/inode.c

index 6d11c365d7b4ee14b3486c59a2129b929ccd8c34..cde0a3dc80c3efbc884f0be826312655ac570165 100644 (file)
@@ -333,6 +333,16 @@ static bool sanity_check_inode(struct inode *inode, struct page *node_page)
        return true;
 }
 
+static void init_idisk_time(struct inode *inode)
+{
+       struct f2fs_inode_info *fi = F2FS_I(inode);
+
+       fi->i_disk_time[0] = inode->i_atime;
+       fi->i_disk_time[1] = inode->i_ctime;
+       fi->i_disk_time[2] = inode->i_mtime;
+       fi->i_disk_time[3] = fi->i_crtime;
+}
+
 static int do_read_inode(struct inode *inode)
 {
        struct f2fs_sb_info *sbi = F2FS_I_SB(inode);
@@ -465,10 +475,7 @@ static int do_read_inode(struct inode *inode)
                }
        }
 
-       fi->i_disk_time[0] = inode->i_atime;
-       fi->i_disk_time[1] = inode->i_ctime;
-       fi->i_disk_time[2] = inode->i_mtime;
-       fi->i_disk_time[3] = fi->i_crtime;
+       init_idisk_time(inode);
        f2fs_put_page(node_page, 1);
 
        stat_inc_inline_xattr(inode);
@@ -676,11 +683,7 @@ void f2fs_update_inode(struct inode *inode, struct page *node_page)
        if (inode->i_nlink == 0)
                clear_page_private_inline(node_page);
 
-       F2FS_I(inode)->i_disk_time[0] = inode->i_atime;
-       F2FS_I(inode)->i_disk_time[1] = inode->i_ctime;
-       F2FS_I(inode)->i_disk_time[2] = inode->i_mtime;
-       F2FS_I(inode)->i_disk_time[3] = F2FS_I(inode)->i_crtime;
-
+       init_idisk_time(inode);
 #ifdef CONFIG_F2FS_CHECK_FS
        f2fs_inode_chksum_set(F2FS_I_SB(inode), node_page);
 #endif