hugolib: Fix .Site.GetPage regression

In Hugo 0.44 we simplified the `.Site.GetPage` API and added code to handle the old-style syntax in most cases.

This logic did not handle the lookup of the home page via `.Site.GetPage "section" ""` and similar. This commit fixes that.

Fixes #4989

diff --git a/hugolib/page_collections.go b/hugolib/page_collections.go
index d196d67a3411cf8d5e08219b730d358a1adf28f3..d99857aec72dd833663c1415eb41fd1e1a10c0cb 100644 (file)
--- a/hugolib/page_collections.go
+++ b/hugolib/page_collections.go
@@ -176,7 +176,14 @@ func (c *PageCollections) getPageOldVersion(ref ...string) (*Page, error) {
        if len(refs) == 0 || refs[0] == KindHome {
                key = "/"
        } else if len(refs) == 1 {
-               key = refs[0]
+               if len(ref) == 2 && refs[0] == KindSection {
+                       // This is an old style reference to the "Home Page section".
+                       // Typically fetched via {{ .Site.GetPage "section" .Section }}
+                       // See https://github.com/gohugoio/hugo/issues/4989
+                       key = "/"
+               } else {
+                       key = refs[0]
+               }
        } else {
                key = refs[1]
        }

diff --git a/hugolib/site_sections_test.go b/hugolib/site_sections_test.go
index bfec623e52fd73c62f65eb37d9334c00d3f282ec..86ae4080cb92f0b3397f234f17f86af0a0715ec5 100644 (file)
--- a/hugolib/site_sections_test.go
+++ b/hugolib/site_sections_test.go
@@ -109,6 +109,8 @@ Content
 {{ range .Paginator.Pages }}
 PAG|{{ .Title }}|{{ $sect.InSection . }}
 {{ end }}
+{{/* https://github.com/gohugoio/hugo/issues/4989 */}}
+{{ $sections := (.Site.GetPage "section" .Section).Sections.ByWeight }}
 </html>`)
 
        cfg.Set("paginate", 2)