net: mana: Add handling of CQE_RX_TRUNCATED
authorHaiyang Zhang <haiyangz@microsoft.com>
Fri, 4 Feb 2022 22:45:44 +0000 (14:45 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 25 Jun 2022 13:18:40 +0000 (15:18 +0200)
commit e4b7621982d29f26ff4d39af389e5e675a4ffed4 upstream.

The proper way to drop this kind of CQE is advancing rxq tail
without indicating the packet to the upper network layer.

Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Reviewed-by: Dexuan Cui <decui@microsoft.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/microsoft/mana/mana_en.c

index 030ae89f3a337abb52568185b494c15945e309f5..18dc64d7f412ffaa6bc8aa460560c8072ed51c2b 100644 (file)
@@ -980,8 +980,10 @@ static void mana_process_rx_cqe(struct mana_rxq *rxq, struct mana_cq *cq,
                break;
 
        case CQE_RX_TRUNCATED:
-               netdev_err(ndev, "Dropped a truncated packet\n");
-               return;
+               ++ndev->stats.rx_dropped;
+               rxbuf_oob = &rxq->rx_oobs[rxq->buf_index];
+               netdev_warn_once(ndev, "Dropped a truncated packet\n");
+               goto drop;
 
        case CQE_RX_COALESCED_4:
                netdev_err(ndev, "RX coalescing is unsupported\n");
@@ -1043,6 +1045,7 @@ static void mana_process_rx_cqe(struct mana_rxq *rxq, struct mana_cq *cq,
 
        mana_rx_skb(old_buf, oob, rxq);
 
+drop:
        mana_move_wq_tail(rxq->gdma_rq, rxbuf_oob->wqe_inf.wqe_size_in_bu);
 
        mana_post_pkt_rxq(rxq);