remoteproc: qcom_q6v5_mss: Replace ioremap with memremap
authorSibi Sankar <sibis@codeaurora.org>
Wed, 4 Nov 2020 07:03:41 +0000 (12:33 +0530)
committerBjorn Andersson <bjorn.andersson@linaro.org>
Tue, 24 Nov 2020 16:19:02 +0000 (10:19 -0600)
Fix the sparse warnings reported by the kernel test bot by replacing
ioremap calls with memremap.

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
Link: https://lore.kernel.org/r/1604473422-29639-1-git-send-email-sibis@codeaurora.org
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
drivers/remoteproc/qcom_q6v5_mss.c

index 9a473cfef758882fa065fa1f36fdaf245600fd55..2c866b6da23c4ae1b57b94479fda8256247894e7 100644 (file)
@@ -1194,7 +1194,7 @@ static int q6v5_mpss_load(struct q6v5 *qproc)
                        goto release_firmware;
                }
 
-               ptr = ioremap_wc(qproc->mpss_phys + offset, phdr->p_memsz);
+               ptr = memremap(qproc->mpss_phys + offset, phdr->p_memsz, MEMREMAP_WC);
                if (!ptr) {
                        dev_err(qproc->dev,
                                "unable to map memory region: %pa+%zx-%x\n",
@@ -1209,7 +1209,7 @@ static int q6v5_mpss_load(struct q6v5 *qproc)
                                        "failed to load segment %d from truncated file %s\n",
                                        i, fw_name);
                                ret = -EINVAL;
-                               iounmap(ptr);
+                               memunmap(ptr);
                                goto release_firmware;
                        }
 
@@ -1221,7 +1221,7 @@ static int q6v5_mpss_load(struct q6v5 *qproc)
                                                        ptr, phdr->p_filesz);
                        if (ret) {
                                dev_err(qproc->dev, "failed to load %s\n", fw_name);
-                               iounmap(ptr);
+                               memunmap(ptr);
                                goto release_firmware;
                        }
 
@@ -1232,7 +1232,7 @@ static int q6v5_mpss_load(struct q6v5 *qproc)
                        memset(ptr + phdr->p_filesz, 0,
                               phdr->p_memsz - phdr->p_filesz);
                }
-               iounmap(ptr);
+               memunmap(ptr);
                size += phdr->p_memsz;
 
                code_length = readl(qproc->rmb_base + RMB_PMI_CODE_LENGTH_REG);
@@ -1299,11 +1299,11 @@ static void qcom_q6v5_dump_segment(struct rproc *rproc,
        }
 
        if (!ret)
-               ptr = ioremap_wc(qproc->mpss_phys + offset + cp_offset, size);
+               ptr = memremap(qproc->mpss_phys + offset + cp_offset, size, MEMREMAP_WC);
 
        if (ptr) {
                memcpy(dest, ptr, size);
-               iounmap(ptr);
+               memunmap(ptr);
        } else {
                memset(dest, 0xff, size);
        }