crypto: marvell/cesa - Silence gcc format-truncation false positive warnings
authorHerbert Xu <herbert@gondor.apana.org.au>
Fri, 27 Oct 2023 10:35:17 +0000 (18:35 +0800)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 17 Nov 2023 11:16:28 +0000 (19:16 +0800)
The heuristics used by gcc triggers false positive truncation
warnings in hifn_alg_alloc.  The warnings are false positives
because nengines is at most 2.

Make the buffer bigger and change the snprintf to use unsigned
integers to eliminate these warnings.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/marvell/cesa/cesa.c

index 5744df30c83830ecb3f4d60940ea2717885d3686..5fd31ba715c22a1ababe52d272fd991ede682260 100644 (file)
@@ -488,7 +488,7 @@ static int mv_cesa_probe(struct platform_device *pdev)
 
        for (i = 0; i < caps->nengines; i++) {
                struct mv_cesa_engine *engine = &cesa->engines[i];
-               char res_name[7];
+               char res_name[16];
 
                engine->id = i;
                spin_lock_init(&engine->lock);
@@ -509,7 +509,7 @@ static int mv_cesa_probe(struct platform_device *pdev)
                 * Not all platforms can gate the CESA clocks: do not complain
                 * if the clock does not exist.
                 */
-               snprintf(res_name, sizeof(res_name), "cesa%d", i);
+               snprintf(res_name, sizeof(res_name), "cesa%u", i);
                engine->clk = devm_clk_get(dev, res_name);
                if (IS_ERR(engine->clk)) {
                        engine->clk = devm_clk_get(dev, NULL);
@@ -517,7 +517,7 @@ static int mv_cesa_probe(struct platform_device *pdev)
                                engine->clk = NULL;
                }
 
-               snprintf(res_name, sizeof(res_name), "cesaz%d", i);
+               snprintf(res_name, sizeof(res_name), "cesaz%u", i);
                engine->zclk = devm_clk_get(dev, res_name);
                if (IS_ERR(engine->zclk))
                        engine->zclk = NULL;