scsi: lpfc: Remove unnecessary zero return code assignment in lpfc_sli4_hba_setup

In order to enter the !rc if statement block in question, rc had to have
been zero to begin with.  Thus, the rc = 0 assignment is unnecessary and
can be removed.

Signed-off-by: Justin Tee <justin.tee@broadcom.com>
Link: https://lore.kernel.org/r/20231009161812.97232-2-justintee8345@gmail.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c
index 4dfadf254a72710564136371032ff460e77a1051..9386e7b447506915110a8ba0299538bad1438ad0 100644 (file)
--- a/drivers/scsi/lpfc/lpfc_sli.c
+++ b/drivers/scsi/lpfc/lpfc_sli.c
@@ -8571,12 +8571,10 @@ lpfc_sli4_hba_setup(struct lpfc_hba *phba)
         * is not fatal as the driver will use generic values.
         */
        rc = lpfc_parse_vpd(phba, vpd, vpd_size);
-       if (unlikely(!rc)) {
+       if (unlikely(!rc))
                lpfc_printf_log(phba, KERN_ERR, LOG_TRACE_EVENT,
                                "0377 Error %d parsing vpd. "
                                "Using defaults.\n", rc);
-               rc = 0;
-       }
        kfree(vpd);
 
        /* Save information as VPD data */