irqchip/gic-v3-its: Split property table clearing from allocation
authorMarc Zyngier <marc.zyngier@arm.com>
Fri, 27 Jul 2018 14:02:27 +0000 (15:02 +0100)
committerMarc Zyngier <marc.zyngier@arm.com>
Tue, 2 Oct 2018 09:37:29 +0000 (10:37 +0100)
As we're going to reuse some pre-allocated memory for the property
table, split out the zeroing of that table into a separate function
for later use.

Tested-by: Jeremy Linton <jeremy.linton@arm.com>
Tested-by: Bhupesh Sharma <bhsharma@redhat.com>
Tested-by: Lei Zhang <zhang.lei@jp.fujitsu.com>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
drivers/irqchip/irq-gic-v3-its.c

index 842760a0f893180f4f456885eb212e690a1baa8c..cb59a4d513c9032e043b2940102c2364e4ad2c77 100644 (file)
@@ -1597,6 +1597,15 @@ static void its_lpi_free(unsigned long *bitmap, u32 base, u32 nr_ids)
        kfree(bitmap);
 }
 
+static void gic_reset_prop_table(void *va)
+{
+       /* Priority 0xa0, Group-1, disabled */
+       memset(va, LPI_PROP_DEFAULT_PRIO | LPI_PROP_GROUP1, LPI_PROPBASE_SZ);
+
+       /* Make sure the GIC will observe the written configuration */
+       gic_flush_dcache_to_poc(va, LPI_PROPBASE_SZ);
+}
+
 static struct page *its_allocate_prop_table(gfp_t gfp_flags)
 {
        struct page *prop_page;
@@ -1605,13 +1614,7 @@ static struct page *its_allocate_prop_table(gfp_t gfp_flags)
        if (!prop_page)
                return NULL;
 
-       /* Priority 0xa0, Group-1, disabled */
-       memset(page_address(prop_page),
-              LPI_PROP_DEFAULT_PRIO | LPI_PROP_GROUP1,
-              LPI_PROPBASE_SZ);
-
-       /* Make sure the GIC will observe the written configuration */
-       gic_flush_dcache_to_poc(page_address(prop_page), LPI_PROPBASE_SZ);
+       gic_reset_prop_table(page_address(prop_page));
 
        return prop_page;
 }