projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
a284778
)
drm/i915/trace: i915_request.prio is a signed value
author
Chris Wilson
<chris@chris-wilson.co.uk>
Tue, 28 Jan 2020 15:16:47 +0000
(15:16 +0000)
committer
Chris Wilson
<chris@chris-wilson.co.uk>
Tue, 28 Jan 2020 15:53:36 +0000
(15:53 +0000)
Don't confuse the poor developer by writing a negative value as a very
large positive, as the flow of requests is already complex enough.
Reported-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Link:
https://patchwork.freedesktop.org/patch/msgid/20200128151647.3820659-1-chris@chris-wilson.co.uk
drivers/gpu/drm/i915/i915_trace.h
patch
|
blob
|
history
diff --git
a/drivers/gpu/drm/i915/i915_trace.h
b/drivers/gpu/drm/i915/i915_trace.h
index 162c76a9d1e88d504713ebe9841b76c15e0196c3..bc854ad60954c3d1d64482e7ac7af4dfabda3e0b 100644
(file)
--- a/
drivers/gpu/drm/i915/i915_trace.h
+++ b/
drivers/gpu/drm/i915/i915_trace.h
@@
-800,7
+800,7
@@
TRACE_EVENT(i915_request_in,
__field(u16, instance)
__field(u32, seqno)
__field(u32, port)
- __field(
u
32, prio)
+ __field(
s
32, prio)
),
TP_fast_assign(
@@
-813,7
+813,7
@@
TRACE_EVENT(i915_request_in,
__entry->port = port;
),
- TP_printk("dev=%u, engine=%u:%u, ctx=%llu, seqno=%u, prio=%
u
, port=%u",
+ TP_printk("dev=%u, engine=%u:%u, ctx=%llu, seqno=%u, prio=%
d
, port=%u",
__entry->dev, __entry->class, __entry->instance,
__entry->ctx, __entry->seqno,
__entry->prio, __entry->port)