leds: Remove ide-disk trigger
authorCorentin Labbe <clabbe@baylibre.com>
Tue, 31 Jan 2023 14:03:04 +0000 (14:03 +0000)
committerLee Jones <lee@kernel.org>
Sat, 4 Feb 2023 15:18:17 +0000 (15:18 +0000)
No user of ide-disk remains, so remove this deprecated trigger.
Only a few platforms used this and were fixed in 2016.

Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
Acked-by: Rob Herring <robh@kernel.org>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Lee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/20230131140304.626779-2-clabbe@baylibre.com
Documentation/devicetree/bindings/leds/common.yaml
drivers/leds/trigger/ledtrig-disk.c

index 60c8611c6611bab9af787290c1cddd4bb7ea367e..15e3f6645682ebf5ded568e8ec9cc2965fe1e43b 100644 (file)
@@ -92,9 +92,6 @@ properties:
           - disk-activity
           - disk-read
           - disk-write
-            # LED indicates IDE disk activity (deprecated), in new implementations
-            # use "disk-activity"
-          - ide-disk
             # LED flashes at a fixed, configurable rate
           - timer
             # LED alters the brightness for the specified duration with one software
index 0741910785bbb2f56f4ab38d1fb43479323df3db..0b7dfbd042733921e88c2c5d2be74199e927078b 100644 (file)
@@ -16,7 +16,6 @@
 DEFINE_LED_TRIGGER(ledtrig_disk);
 DEFINE_LED_TRIGGER(ledtrig_disk_read);
 DEFINE_LED_TRIGGER(ledtrig_disk_write);
-DEFINE_LED_TRIGGER(ledtrig_ide);
 
 void ledtrig_disk_activity(bool write)
 {
@@ -24,8 +23,6 @@ void ledtrig_disk_activity(bool write)
 
        led_trigger_blink_oneshot(ledtrig_disk,
                                  &blink_delay, &blink_delay, 0);
-       led_trigger_blink_oneshot(ledtrig_ide,
-                                 &blink_delay, &blink_delay, 0);
        if (write)
                led_trigger_blink_oneshot(ledtrig_disk_write,
                                          &blink_delay, &blink_delay, 0);
@@ -40,7 +37,6 @@ static int __init ledtrig_disk_init(void)
        led_trigger_register_simple("disk-activity", &ledtrig_disk);
        led_trigger_register_simple("disk-read", &ledtrig_disk_read);
        led_trigger_register_simple("disk-write", &ledtrig_disk_write);
-       led_trigger_register_simple("ide-disk", &ledtrig_ide);
 
        return 0;
 }