projects / linux.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: f23a566)
net: ipa: fix v3.1 resource limit masks
authorCaleb Connolly <caleb.connolly@linaro.org>
Mon, 24 Oct 2022 21:03:32 +0000 (22:03 +0100)
committerJakub Kicinski <kuba@kernel.org>
Wed, 26 Oct 2022 02:48:58 +0000 (19:48 -0700)
The resource group limits for IPA v3.1 mistakenly used 6 bit wide mask
values, when the hardware actually uses 8. Out of range values were
silently ignored before, so the IPA worked as expected. However the
new generalised register definitions introduce stricter checking here,
they now cause some splats and result in the value 0 being written
instead. Fix the limit bitmask widths so that the correct values can be
written.

Fixes: 1c418c4a929c ("net: ipa: define resource group/type IPA register fields")
Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
Reviewed-by: Alex Elder <elder@linaro.org>
Tested-by: Jami Kettunen <jami.kettunen@somainline.org>
Link: https://lore.kernel.org/r/20221024210336.4014983-2-caleb.connolly@linaro.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ipa/reg/ipa_reg-v3.1.c patch | blob | history

diff --git a/drivers/net/ipa/reg/ipa_reg-v3.1.c b/drivers/net/ipa/reg/ipa_reg-v3.1.c
index 116b27717e3d785542480cd76ab4b2fd8bb9e403..0d002c3c38a2687aebba48ddec6dd8d587bbdfd4 100644 (file)
--- a/drivers/net/ipa/reg/ipa_reg-v3.1.c
+++ b/drivers/net/ipa/reg/ipa_reg-v3.1.c
@@ -127,112 +127,80 @@ static const u32 ipa_reg_counter_cfg_fmask[] = {
 IPA_REG_FIELDS(COUNTER_CFG, counter_cfg, 0x000001f0);
 
 static const u32 ipa_reg_src_rsrc_grp_01_rsrc_type_fmask[] = {
-       [X_MIN_LIM]                                     = GENMASK(5, 0),
-                                               /* Bits 6-7 reserved */
-       [X_MAX_LIM]                                     = GENMASK(13, 8),
-                                               /* Bits 14-15 reserved */
-       [Y_MIN_LIM]                                     = GENMASK(21, 16),
-                                               /* Bits 22-23 reserved */
-       [Y_MAX_LIM]                                     = GENMASK(29, 24),
-                                               /* Bits 30-31 reserved */
+       [X_MIN_LIM]                                     = GENMASK(7, 0),
+       [X_MAX_LIM]                                     = GENMASK(15, 8),
+       [Y_MIN_LIM]                                     = GENMASK(23, 16),
+       [Y_MAX_LIM]                                     = GENMASK(31, 24),
 };
 
 IPA_REG_STRIDE_FIELDS(SRC_RSRC_GRP_01_RSRC_TYPE, src_rsrc_grp_01_rsrc_type,
                      0x00000400, 0x0020);
 
 static const u32 ipa_reg_src_rsrc_grp_23_rsrc_type_fmask[] = {
-       [X_MIN_LIM]                                     = GENMASK(5, 0),
-                                               /* Bits 6-7 reserved */
-       [X_MAX_LIM]                                     = GENMASK(13, 8),
-                                               /* Bits 14-15 reserved */
-       [Y_MIN_LIM]                                     = GENMASK(21, 16),
-                                               /* Bits 22-23 reserved */
-       [Y_MAX_LIM]                                     = GENMASK(29, 24),
-                                               /* Bits 30-31 reserved */
+       [X_MIN_LIM]                                     = GENMASK(7, 0),
+       [X_MAX_LIM]                                     = GENMASK(15, 8),
+       [Y_MIN_LIM]                                     = GENMASK(23, 16),
+       [Y_MAX_LIM]                                     = GENMASK(31, 24),
 };
 
 IPA_REG_STRIDE_FIELDS(SRC_RSRC_GRP_23_RSRC_TYPE, src_rsrc_grp_23_rsrc_type,
                      0x00000404, 0x0020);
 
 static const u32 ipa_reg_src_rsrc_grp_45_rsrc_type_fmask[] = {
-       [X_MIN_LIM]                                     = GENMASK(5, 0),
-                                               /* Bits 6-7 reserved */
-       [X_MAX_LIM]                                     = GENMASK(13, 8),
-                                               /* Bits 14-15 reserved */
-       [Y_MIN_LIM]                                     = GENMASK(21, 16),
-                                               /* Bits 22-23 reserved */
-       [Y_MAX_LIM]                                     = GENMASK(29, 24),
-                                               /* Bits 30-31 reserved */
+       [X_MIN_LIM]                                     = GENMASK(7, 0),
+       [X_MAX_LIM]                                     = GENMASK(15, 8),
+       [Y_MIN_LIM]                                     = GENMASK(23, 16),
+       [Y_MAX_LIM]                                     = GENMASK(31, 24),
 };
 
 IPA_REG_STRIDE_FIELDS(SRC_RSRC_GRP_45_RSRC_TYPE, src_rsrc_grp_45_rsrc_type,
                      0x00000408, 0x0020);
 
 static const u32 ipa_reg_src_rsrc_grp_67_rsrc_type_fmask[] = {
-       [X_MIN_LIM]                                     = GENMASK(5, 0),
-                                               /* Bits 6-7 reserved */
-       [X_MAX_LIM]                                     = GENMASK(13, 8),
-                                               /* Bits 14-15 reserved */
-       [Y_MIN_LIM]                                     = GENMASK(21, 16),
-                                               /* Bits 22-23 reserved */
-       [Y_MAX_LIM]                                     = GENMASK(29, 24),
-                                               /* Bits 30-31 reserved */
+       [X_MIN_LIM]                                     = GENMASK(7, 0),
+       [X_MAX_LIM]                                     = GENMASK(15, 8),
+       [Y_MIN_LIM]                                     = GENMASK(23, 16),
+       [Y_MAX_LIM]                                     = GENMASK(31, 24),
 };
 
 IPA_REG_STRIDE_FIELDS(SRC_RSRC_GRP_67_RSRC_TYPE, src_rsrc_grp_67_rsrc_type,
                      0x0000040c, 0x0020);
 
 static const u32 ipa_reg_dst_rsrc_grp_01_rsrc_type_fmask[] = {
-       [X_MIN_LIM]                                     = GENMASK(5, 0),
-                                               /* Bits 6-7 reserved */
-       [X_MAX_LIM]                                     = GENMASK(13, 8),
-                                               /* Bits 14-15 reserved */
-       [Y_MIN_LIM]                                     = GENMASK(21, 16),
-                                               /* Bits 22-23 reserved */
-       [Y_MAX_LIM]                                     = GENMASK(29, 24),
-                                               /* Bits 30-31 reserved */
+       [X_MIN_LIM]                                     = GENMASK(7, 0),
+       [X_MAX_LIM]                                     = GENMASK(15, 8),
+       [Y_MIN_LIM]                                     = GENMASK(23, 16),
+       [Y_MAX_LIM]                                     = GENMASK(31, 24),
 };
 
 IPA_REG_STRIDE_FIELDS(DST_RSRC_GRP_01_RSRC_TYPE, dst_rsrc_grp_01_rsrc_type,
                      0x00000500, 0x0020);
 
 static const u32 ipa_reg_dst_rsrc_grp_23_rsrc_type_fmask[] = {
-       [X_MIN_LIM]                                     = GENMASK(5, 0),
-                                               /* Bits 6-7 reserved */
-       [X_MAX_LIM]                                     = GENMASK(13, 8),
-                                               /* Bits 14-15 reserved */
-       [Y_MIN_LIM]                                     = GENMASK(21, 16),
-                                               /* Bits 22-23 reserved */
-       [Y_MAX_LIM]                                     = GENMASK(29, 24),
-                                               /* Bits 30-31 reserved */
+       [X_MIN_LIM]                                     = GENMASK(7, 0),
+       [X_MAX_LIM]                                     = GENMASK(15, 8),
+       [Y_MIN_LIM]                                     = GENMASK(23, 16),
+       [Y_MAX_LIM]                                     = GENMASK(31, 24),
 };
 
 IPA_REG_STRIDE_FIELDS(DST_RSRC_GRP_23_RSRC_TYPE, dst_rsrc_grp_23_rsrc_type,
                      0x00000504, 0x0020);
 
 static const u32 ipa_reg_dst_rsrc_grp_45_rsrc_type_fmask[] = {
-       [X_MIN_LIM]                                     = GENMASK(5, 0),
-                                               /* Bits 6-7 reserved */
-       [X_MAX_LIM]                                     = GENMASK(13, 8),
-                                               /* Bits 14-15 reserved */
-       [Y_MIN_LIM]                                     = GENMASK(21, 16),
-                                               /* Bits 22-23 reserved */
-       [Y_MAX_LIM]                                     = GENMASK(29, 24),
-                                               /* Bits 30-31 reserved */
+       [X_MIN_LIM]                                     = GENMASK(7, 0),
+       [X_MAX_LIM]                                     = GENMASK(15, 8),
+       [Y_MIN_LIM]                                     = GENMASK(23, 16),
+       [Y_MAX_LIM]                                     = GENMASK(31, 24),
 };
 
 IPA_REG_STRIDE_FIELDS(DST_RSRC_GRP_45_RSRC_TYPE, dst_rsrc_grp_45_rsrc_type,
                      0x00000508, 0x0020);
 
 static const u32 ipa_reg_dst_rsrc_grp_67_rsrc_type_fmask[] = {
-       [X_MIN_LIM]                                     = GENMASK(5, 0),
-                                               /* Bits 6-7 reserved */
-       [X_MAX_LIM]                                     = GENMASK(13, 8),
-                                               /* Bits 14-15 reserved */
-       [Y_MIN_LIM]                                     = GENMASK(21, 16),
-                                               /* Bits 22-23 reserved */
-       [Y_MAX_LIM]                                     = GENMASK(29, 24),
-                                               /* Bits 30-31 reserved */
+       [X_MIN_LIM]                                     = GENMASK(7, 0),
+       [X_MAX_LIM]                                     = GENMASK(15, 8),
+       [Y_MIN_LIM]                                     = GENMASK(23, 16),
+       [Y_MAX_LIM]                                     = GENMASK(31, 24),
 };
 
 IPA_REG_STRIDE_FIELDS(DST_RSRC_GRP_67_RSRC_TYPE, dst_rsrc_grp_67_rsrc_type,
ep93xx device tree rework repo: git://git.maquefel.me/linux.git