staging: vt6655: Replace MACvTransmitAC0 with function vt6655_mac_dma_ctl

Convert macro MACvTransmitAC0 to existing static function. This saves
codelines and multiline macros are not liked by kernel community.

Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/013abd177d9ac129c034776f10cdf823fd87d781.1659080988.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
index ec26d2d29d8412069358eeb7a6f1bea06dc8422c..8db655742bd41ce11cbae16f82aa56f6b70dea4c 100644 (file)
--- a/drivers/staging/vt6655/device_main.c
+++ b/drivers/staging/vt6655/device_main.c
@@ -1229,7 +1229,7 @@ static int vnt_tx_packet(struct vnt_private *priv, struct sk_buff *skb)
        wmb(); /* second memory barrier */
 
        if (head_td->td_info->flags & TD_FLAGS_NETIF_SKB)
-               MACvTransmitAC0(priv->port_offset);
+               vt6655_mac_dma_ctl(priv->port_offset, MAC_REG_AC0DMACTL);
        else
                vt6655_mac_dma_ctl(priv->port_offset, MAC_REG_TXDMACTL0);
 

diff --git a/drivers/staging/vt6655/mac.h b/drivers/staging/vt6655/mac.h
index be33da59dd84f413ecbdc5ec05961f6a130d0b81..467c599a32894093f20c7399b265a48a5a3d2c2b 100644 (file)
--- a/drivers/staging/vt6655/mac.h
+++ b/drivers/staging/vt6655/mac.h
@@ -537,16 +537,6 @@
 
 /*---------------------  Export Macros ------------------------------*/
 
-#define MACvTransmitAC0(iobase)                                        \
-do {                                                                   \
-       unsigned long dwData;                                           \
-       dwData = ioread32(iobase + MAC_REG_AC0DMACTL);                  \
-       if (dwData & DMACTL_RUN)                                        \
-               iowrite32(DMACTL_WAKE, iobase + MAC_REG_AC0DMACTL);     \
-       else                                                            \
-               iowrite32(DMACTL_RUN, iobase + MAC_REG_AC0DMACTL);      \
-} while (0)
-
 #define MACvSelectPage0(iobase)                                \
        iowrite8(0, iobase + MAC_REG_PAGE1SEL)