media: i2c: tc358746: fix missing return assignment

It was intended to return an error if tc358746_update_bits() call fail.
Fix this by storing the return code.

Addresses-Coverity-ID: 1527252 ("Control flow issues")

Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Fixes: 80a21da36051 ("media: tc358746: add Toshiba TC358746 Parallel to CSI-2 bridge driver")
Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>

diff --git a/drivers/media/i2c/tc358746.c b/drivers/media/i2c/tc358746.c
index d1f552bd81d42eba042f600dc8bf82576becd3fd..e7f27cbb5790781efa4cf768d7b2f68f5c4f4d5a 100644 (file)
--- a/drivers/media/i2c/tc358746.c
+++ b/drivers/media/i2c/tc358746.c
@@ -406,7 +406,7 @@ tc358746_apply_pll_config(struct tc358746 *tc358746)
 
        val = PLL_FRS(ilog2(post)) | RESETB | PLL_EN;
        mask = PLL_FRS_MASK | RESETB | PLL_EN;
-       tc358746_update_bits(tc358746, PLLCTL1_REG, mask, val);
+       err = tc358746_update_bits(tc358746, PLLCTL1_REG, mask, val);
        if (err)
                return err;