staging: rtl8192u: ieee80211_softmac: Move a large data struct onto the heap

Fixes the following W=1 kernel build warning(s):

 drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c: In function ‘ieee80211_rx_frame_softmac’:
 drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:2009:1: warning: the frame size of 1152 bytes is larger than 1024 bytes [-Wframe-larger-than=]

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Romain Perier <romain.perier@gmail.com>
Cc: Allen Pais <apais@linux.microsoft.com>
Cc: Andrea Merello <andrea.merello@gmail.com>
Cc: linux-staging@lists.linux.dev
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Link: https://lore.kernel.org/r/20210414181129.1628598-29-lee.jones@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
index 25ea8e1b6b65dd5e88688b4319f2cff6b183f52e..965fa1fb5e1b0f4e9fa311ef28cf3554f7f0c650 100644 (file)
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
@@ -1911,8 +1911,11 @@ ieee80211_rx_frame_softmac(struct ieee80211_device *ieee, struct sk_buff *skb,
                if ((ieee->softmac_features & IEEE_SOFTMAC_ASSOCIATE) &&
                    ieee->state == IEEE80211_ASSOCIATING_AUTHENTICATED &&
                    ieee->iw_mode == IW_MODE_INFRA) {
-                       struct ieee80211_network network_resp;
-                       struct ieee80211_network *network = &network_resp;
+                       struct ieee80211_network *network;
+
+                       network = kzalloc(sizeof(*network), GFP_KERNEL);
+                       if (!network)
+                               return -ENOMEM;
 
                        errcode = assoc_parse(ieee, skb, &aid);
                        if (!errcode) {
@@ -1923,7 +1926,6 @@ ieee80211_rx_frame_softmac(struct ieee80211_device *ieee, struct sk_buff *skb,
                                /* Let the register setting defaultly with Legacy station */
                                if (ieee->qos_support) {
                                        assoc_resp = (struct ieee80211_assoc_response_frame *)skb->data;
-                                       memset(network, 0, sizeof(*network));
                                        if (ieee80211_parse_info_param(ieee, assoc_resp->info_element,\
                                                                       rx_stats->len - sizeof(*assoc_resp), \
                                                                       network, rx_stats)) {
@@ -1949,6 +1951,7 @@ ieee80211_rx_frame_softmac(struct ieee80211_device *ieee, struct sk_buff *skb,
                                else
                                        ieee80211_associate_abort(ieee);
                        }
+                       kfree(network);
                }
                break;