wifi: iwlwifi: mvm: combine condition/warning
authorJohannes Berg <johannes.berg@intel.com>
Mon, 5 Feb 2024 19:21:10 +0000 (21:21 +0200)
committerJohannes Berg <johannes.berg@intel.com>
Thu, 8 Feb 2024 14:00:47 +0000 (15:00 +0100)
WARN() returns the value of the condition, so it's
nicer to combine the warning and the if.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Miri Korenblit <miriam.rachel.korenblit@intel.com>
Link: https://msgid.link/20240205211151.44f63334760e.If0a2cf347a8676a3830c5c3183a257fe11f31419@changeid
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c

index 7979b7952a79761ca5994231895ce1d9b12972a1..7c0da3b8ad77af6de9a6ad783a70ba24b086d0fd 100644 (file)
@@ -649,10 +649,8 @@ static void iwl_mvm_release_frames_from_notif(struct iwl_mvm *mvm,
        rcu_read_lock();
 
        ba_data = rcu_dereference(mvm->baid_map[baid]);
-       if (!ba_data) {
-               WARN(true, "BAID %d not found in map\n", baid);
+       if (WARN(!ba_data, "BAID %d not found in map\n", baid))
                goto out;
-       }
 
        /* pick any STA ID to find the pointer */
        sta_id = ffs(ba_data->sta_mask) - 1;