drm/panel-boe-bf060y8m-aj0: Drop custom DSI write macro
authorJavier Martinez Canillas <javierm@redhat.com>
Sat, 7 Jan 2023 19:18:14 +0000 (20:18 +0100)
committerJavier Martinez Canillas <javierm@redhat.com>
Wed, 11 Jan 2023 17:50:49 +0000 (18:50 +0100)
There is a macro for this already in the <drm/drm_mipi_dsi.h> header, use
that instead and delete the custom DSI write macro defined in the driver.

Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20230107191822.3787147-6-javierm@redhat.com
drivers/gpu/drm/panel/panel-boe-bf060y8m-aj0.c

index ad58840eda41868781717e111f2d31dbaef7640d..90098b753e3b9c9857fd952c22eb8cb4d368beb4 100644 (file)
@@ -43,14 +43,6 @@ struct boe_bf060y8m_aj0 *to_boe_bf060y8m_aj0(struct drm_panel *panel)
        return container_of(panel, struct boe_bf060y8m_aj0, panel);
 }
 
-#define dsi_dcs_write_seq(dsi, seq...) do {                            \
-               static const u8 d[] = { seq };                          \
-               int ret;                                                \
-               ret = mipi_dsi_dcs_write_buffer(dsi, d, ARRAY_SIZE(d)); \
-               if (ret < 0)                                            \
-                       return ret;                                     \
-       } while (0)
-
 static void boe_bf060y8m_aj0_reset(struct boe_bf060y8m_aj0 *boe)
 {
        gpiod_set_value_cansleep(boe->reset_gpio, 0);
@@ -67,12 +59,12 @@ static int boe_bf060y8m_aj0_on(struct boe_bf060y8m_aj0 *boe)
        struct device *dev = &dsi->dev;
        int ret;
 
-       dsi_dcs_write_seq(dsi, 0xb0, 0xa5, 0x00);
-       dsi_dcs_write_seq(dsi, 0xb2, 0x00, 0x4c);
-       dsi_dcs_write_seq(dsi, MIPI_DCS_SET_3D_CONTROL, 0x10);
-       dsi_dcs_write_seq(dsi, MIPI_DCS_WRITE_POWER_SAVE, DCS_ALLOW_HBM_RANGE);
-       dsi_dcs_write_seq(dsi, 0xf8,
-                         0x00, 0x08, 0x10, 0x00, 0x22, 0x00, 0x00, 0x2d);
+       mipi_dsi_dcs_write_seq(dsi, 0xb0, 0xa5, 0x00);
+       mipi_dsi_dcs_write_seq(dsi, 0xb2, 0x00, 0x4c);
+       mipi_dsi_dcs_write_seq(dsi, MIPI_DCS_SET_3D_CONTROL, 0x10);
+       mipi_dsi_dcs_write_seq(dsi, MIPI_DCS_WRITE_POWER_SAVE, DCS_ALLOW_HBM_RANGE);
+       mipi_dsi_dcs_write_seq(dsi, 0xf8,
+                              0x00, 0x08, 0x10, 0x00, 0x22, 0x00, 0x00, 0x2d);
 
        ret = mipi_dsi_dcs_exit_sleep_mode(dsi);
        if (ret < 0) {
@@ -81,17 +73,17 @@ static int boe_bf060y8m_aj0_on(struct boe_bf060y8m_aj0 *boe)
        }
        msleep(30);
 
-       dsi_dcs_write_seq(dsi, 0xb0, 0xa5, 0x00);
-       dsi_dcs_write_seq(dsi, 0xc0,
-                         0x08, 0x48, 0x65, 0x33, 0x33, 0x33,
-                         0x2a, 0x31, 0x39, 0x20, 0x09);
-       dsi_dcs_write_seq(dsi, 0xc1, 0x00, 0x00, 0x00, 0x1f, 0x1f,
-                         0x1f, 0x1f, 0x1f, 0x1f, 0x1f, 0x1f, 0x1f,
-                         0x1f, 0x1f, 0x1f, 0x1f, 0x1f, 0x1f);
-       dsi_dcs_write_seq(dsi, 0xe2, 0x20, 0x04, 0x10, 0x12, 0x92,
-                         0x4f, 0x8f, 0x44, 0x84, 0x83, 0x83, 0x83,
-                         0x5c, 0x5c, 0x5c);
-       dsi_dcs_write_seq(dsi, 0xde, 0x01, 0x2c, 0x00, 0x77, 0x3e);
+       mipi_dsi_dcs_write_seq(dsi, 0xb0, 0xa5, 0x00);
+       mipi_dsi_dcs_write_seq(dsi, 0xc0,
+                              0x08, 0x48, 0x65, 0x33, 0x33, 0x33,
+                              0x2a, 0x31, 0x39, 0x20, 0x09);
+       mipi_dsi_dcs_write_seq(dsi, 0xc1, 0x00, 0x00, 0x00, 0x1f, 0x1f,
+                              0x1f, 0x1f, 0x1f, 0x1f, 0x1f, 0x1f, 0x1f,
+                              0x1f, 0x1f, 0x1f, 0x1f, 0x1f, 0x1f);
+       mipi_dsi_dcs_write_seq(dsi, 0xe2, 0x20, 0x04, 0x10, 0x12, 0x92,
+                              0x4f, 0x8f, 0x44, 0x84, 0x83, 0x83, 0x83,
+                              0x5c, 0x5c, 0x5c);
+       mipi_dsi_dcs_write_seq(dsi, 0xde, 0x01, 0x2c, 0x00, 0x77, 0x3e);
 
        msleep(30);