drm/amdgpu: Remove redundant calls of ras_late_init in mmhub ras block
authoryipechai <YiPeng.Chai@amd.com>
Mon, 14 Feb 2022 06:20:31 +0000 (14:20 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 17 Feb 2022 20:59:04 +0000 (15:59 -0500)
Remove redundant calls of ras_late_init in mmhub ras block.

Signed-off-by: yipechai <YiPeng.Chai@amd.com>
Reviewed-by: Tao Zhou <tao.zhou1@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
drivers/gpu/drm/amd/amdgpu/amdgpu_mmhub.c
drivers/gpu/drm/amd/amdgpu/amdgpu_mmhub.h
drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c

index bf0cc517d3d5370fdc41a4f58a15b84df9ed9a77..ebd4f1459aa45891c0af693cf479bd14cc04071a 100644 (file)
@@ -458,7 +458,7 @@ int amdgpu_gmc_ras_late_init(struct amdgpu_device *adev)
        }
 
        if (adev->mmhub.ras && adev->mmhub.ras->ras_block.ras_late_init) {
-               r = adev->mmhub.ras->ras_block.ras_late_init(adev, NULL);
+               r = adev->mmhub.ras->ras_block.ras_late_init(adev, adev->mmhub.ras_if);
                if (r)
                        return r;
        }
index ede98db8c126a94f2725932d13af65ed89b0ed1c..42413813765adbc2f62267623155ea646aaaa41c 100644 (file)
 #include "amdgpu.h"
 #include "amdgpu_ras.h"
 
-int amdgpu_mmhub_ras_late_init(struct amdgpu_device *adev, struct ras_common_if *ras_block)
-{
-       return amdgpu_ras_block_late_init(adev, adev->mmhub.ras_if);
-}
-
 void amdgpu_mmhub_ras_fini(struct amdgpu_device *adev)
 {
        if (amdgpu_ras_is_supported(adev, AMDGPU_RAS_BLOCK__MMHUB) &&
index 75815106f2d5eabe03704e02ddc9723a029a3d6d..240b26d9a388e2807d8ba16fb99cab05359f4089 100644 (file)
@@ -47,7 +47,6 @@ struct amdgpu_mmhub {
        struct amdgpu_mmhub_ras  *ras;
 };
 
-int amdgpu_mmhub_ras_late_init(struct amdgpu_device *adev, struct ras_common_if *ras_block);
 void amdgpu_mmhub_ras_fini(struct amdgpu_device *adev);
 #endif
 
index 94095b965e2c94b03ea94522c79582687a334da3..b719d2c3003b7dbb89a97a7e941d25b9f048adba 100644 (file)
@@ -1293,7 +1293,7 @@ static void gmc_v9_0_set_mmhub_ras_funcs(struct amdgpu_device *adev)
 
                /* If don't define special ras_late_init function, use default ras_late_init */
                if (!adev->mmhub.ras->ras_block.ras_late_init)
-                       adev->mmhub.ras->ras_block.ras_late_init = amdgpu_mmhub_ras_late_init;
+                       adev->mmhub.ras->ras_block.ras_late_init = amdgpu_ras_block_late_init;
 
                /* If don't define special ras_fini function, use default ras_fini */
                if (!adev->mmhub.ras->ras_block.ras_fini)